Skip to content

feat(checkbox): indeterminate support for options in a checkbox group #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

EmiyaYang
Copy link

This is a ...

  • New feature

What's the background?

#1788

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.
// checkbox-group's option item support indeterminate field
const options = [
   { value: 'Apple' },
   { label: 'Pear', value: 'Pear' },
   { label: 'Orange', value: 'Orange', indeterminate: true },
];

What's the effect? (Optional if not new feature)

Users can pass the indeterminate as prop via checkbox group's option.

Changelog description (Optional if not new feature)

  1. English description

Indeterminate support for options in a checkbox group

  1. Chinese description (optional)

Checkbox Group 支持通过 option 传递 indeterminate.

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #1831 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1831   +/-   ##
=======================================
  Coverage   88.06%   88.06%           
=======================================
  Files         157      157           
  Lines        5422     5423    +1     
  Branches     1525     1525           
=======================================
+ Hits         4775     4776    +1     
  Misses        578      578           
  Partials       69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f564f6d...91de265. Read the comment docs.

@tangjinzhou
Copy link
Member

有冲突,通过命令行方式 merge 了 尴尬的是最后发现这种方式没有你的记录 抱歉

@EmiyaYang
Copy link
Author

@tangjinzhou 哈哈, 没事. 我还以为哪一步做错了

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants