Skip to content

feat(checkbox): indeterminate support for options in a checkbox group #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

EmiyaYang
Copy link

@EmiyaYang EmiyaYang commented Feb 25, 2020

This is a ...

  • New feature

What's the background?

#1788

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.
// checkbox-group's option item support indeterminate field
const options = [
   { value: 'Apple' },
   { label: 'Pear', value: 'Pear' },
   { label: 'Orange', value: 'Orange', indeterminate: true },
];

What's the effect? (Optional if not new feature)

Users can pass the indeterminate as prop via checkbox group's option.

Changelog description (Optional if not new feature)

  1. English description

Indeterminate support for options in a checkbox group

  1. Chinese description (optional)

Checkbox Group 支持通过 option 传递 indeterminate.

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #1824 into feat-1.4.0 will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feat-1.4.0    #1824   +/-   ##
===========================================
  Coverage       87.60%   87.60%           
===========================================
  Files             156      156           
  Lines            5398     5399    +1     
  Branches         1519     1519           
===========================================
+ Hits             4729     4730    +1     
  Misses            596      596           
  Partials           73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 598f41f...faa1747. Read the comment docs.

@zkwolf
Copy link
Member

zkwolf commented Feb 25, 2020

应该到master吧,feat-1.4.0是1.4.0发布之前的分支

@EmiyaYang
Copy link
Author

@zkwolf 但是新功能不是要推到 feat 吗? 还是说应该推到 feat-1.5.0 ?

@EmiyaYang
Copy link
Author

EmiyaYang commented Feb 27, 2020

我重新提了 #1831

@EmiyaYang EmiyaYang closed this Feb 27, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants