simulation mem leak - latch names array in create latch #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
lang-cpp
jeanlego
reviewed
Oct 17, 2019
ODIN_II/SRC/read_blif.cpp
Outdated
Comment on lines
402
to
406
| for (i = 0; i < input_token_count; i++) | ||
| // Except these two since they were assigned to new_node | ||
| if (i!=0 && i!=3) | ||
| vtr::free(names[i]); | ||
|
|
There was a problem hiding this comment.
do strdup at line 371 and line 376 rather and here simply free them all
avoid complicated logic like this at all cost, change may occur in the code base and this would produce some unexpected side effect down the line
sdamghan
force-pushed
the
simulation_mem_leak_latch_names
branch
from
fb8c0b2 to
2e6dca1
Compare
jeanlego
reviewed
Oct 17, 2019
ODIN_II/SRC/read_blif.cpp
Outdated
| @@ -399,6 +399,10 @@ void create_latch_node_and_driver(FILE *file, Hashtable *output_nets_hash) | |||
| output_nets_hash->add(new_node->name, new_net); | |||
|
|
|||
| /* Free the char** names */ | |||
| for (i = 0; i < input_token_count; i++) | |||
| // Except these two since they were assigned to new_node | |||
There was a problem hiding this comment.
remove that comment since it is not relevant anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How Has This Been Tested?
tested by make test odin
Types of changes
Checklist: