Skip to content

Odin leak pin->mapping #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 17, 2019
Merged

Odin leak pin->mapping #730

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5c36ebb
WIP: ODIN_II leak fix
j-b-1-7 Jul 16, 2019
50f61f8
WIP: ODIN_II leak fix from temp_localparam_list
j-b-1-7 Jul 16, 2019
92651bd
Fixed leak from pin->mapping
j-b-1-7 Jul 16, 2019
8b0fb39
Update netlist_create_from_ast.cpp
j-b-1-7 Jul 16, 2019
91c0975
Update netlist_create_from_ast.cpp
j-b-1-7 Jul 16, 2019
4b88e33
Update netlist_create_from_ast.cpp
j-b-1-7 Jul 16, 2019
b72c3f6
Update netlist_create_from_ast.cpp
j-b-1-7 Jul 16, 2019
21a7f6f
Update memories.cpp
j-b-1-7 Jul 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ODIN_II/SRC/memories.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,8 @@ void split_sp_memory_depth(nnode_t *node, int split_size)

npin_t *pin = signals->out->pins[i];
pin->name = mux->name;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check that the name is null before assignment otherwise it should be freed beforehand

if(pin->mapping)
vtr::free(pin->mapping);
pin->mapping = NULL;

remap_pin_to_new_node(pin, mux, 0);
Expand Down
2 changes: 1 addition & 1 deletion ODIN_II/SRC/netlist_create_from_ast.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6188,4 +6188,4 @@ ast_node_t *get_chunk_size_node(char *instance_name_prefix, char *array_name, ST
}

return array_size;
}
}