Odin leak pin->mapping #730

j-b-1-7 · 2019-07-16T15:07:47Z

Fixed memory leak from pin->mapping being set to NULL before being freed.

Bug fix (change which fixes an issue)
New feature (change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

jeanlego · 2019-07-17T00:40:46Z

ODIN_II/SRC/memories.cpp

@@ -437,6 +437,8 @@ void split_sp_memory_depth(nnode_t *node, int split_size)

 		npin_t *pin = signals->out->pins[i];
 		pin->name = mux->name;


Should check that the name is null before assignment otherwise it should be freed beforehand

j-b-1-7 added 3 commits July 16, 2019 10:46

WIP: ODIN_II leak fix

5c36ebb

WIP: ODIN_II leak fix from temp_localparam_list

50f61f8

Fixed leak from pin->mapping

92651bd

probot-autolabeler bot added lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item labels Jul 16, 2019

j-b-1-7 added 4 commits July 16, 2019 12:08

Update netlist_create_from_ast.cpp

8b0fb39

Update netlist_create_from_ast.cpp

91c0975

Update netlist_create_from_ast.cpp

4b88e33

Update netlist_create_from_ast.cpp

b72c3f6

j-b-1-7 changed the title ~~WIP: Odin leak pin->mapping~~ Odin leak pin->mapping Jul 16, 2019

jeanlego reviewed Jul 17, 2019

View reviewed changes

Update memories.cpp

21a7f6f

jeanlego merged commit 42da0b4 into verilog-to-routing:master Jul 17, 2019

Provide feedback

		@@ -437,6 +437,8 @@ void split_sp_memory_depth(nnode_t *node, int split_size)

		npin_t *pin = signals->out->pins[i];
		pin->name = mux->name;