-
Notifications
You must be signed in to change notification settings - Fork 414
Vpr viewer and flat routing on #3070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
8782a86
83e62d8
104067e
a76ce0f
5ef1caa
61f6c6a
c450851
0f998e6
8fd9c0a
2914dc7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,9 @@ | |
|
||
#include "ezgl/application.hpp" | ||
|
||
bool is_net_unrouted(AtomNetId atomic_net_id); | ||
bool is_net_fully_absorbed(AtomNetId atomic_net_id); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think adding Doxygen comments for these two functions would be better. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did a bit of digging through the codebase and found that the routing context includes a data structure called net_status, which has a method called is_routed. I think it would be better to use that instead of writing a custom function to determine whether a net is routed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The functionality of is_net_fully_absorbed isn't specific to drawing, so I think it would be better to move it to the route_utils file rather than defining it here. |
||
|
||
void search_and_highlight(GtkWidget* /*widget*/, ezgl::application* app); | ||
bool highlight_rr_nodes(RRNodeId hit_node); | ||
void auto_zoom_rr_node(RRNodeId rr_node_id); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more common approach in VTR for iterating over the routing path of a net is to use the route tree (in routing context), which can also be used to check whether a net is routed. I’d suggest using that instead of constructing the net trace manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, add a comment and explain how you determine whether a net is completely absorbed.