Skip to content

Yet another update of the code base to be consistent with code formatting rules #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 18, 2025
Merged

Yet another update of the code base to be consistent with code formatting rules #2935

merged 11 commits into from
Mar 18, 2025

Conversation

soheilshahrouz
Copy link
Contributor

Read #2931.

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool Odin Odin II Logic Synthesis Tool: Unsorted item libarchfpga Library for handling FPGA Architecture descriptions lang-cpp C/C++ code libvtrutil labels Mar 17, 2025
AlexandreSinger
AlexandreSinger reviewed Mar 17, 2025
View reviewed changes
Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, otherwise LGTM.

There are some if statements which are being unwrapped way too much. Is there any way that we can prevent this?

@github-actions github-actions bot added the infra Project Infrastructure label Mar 18, 2025
@github-actions github-actions bot added the lang-python Python code label Mar 18, 2025
@soheilshahrouz soheilshahrouz merged commit 7905df1 into master Mar 18, 2025
36 checks passed
@soheilshahrouz soheilshahrouz deleted the temp_format_try3 branch March 18, 2025 21:48
@soheilshahrouz soheilshahrouz mentioned this pull request Apr 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreSinger AlexandreSinger AlexandreSinger left review comments

@amin1377 amin1377 Awaiting requested review from amin1377

@AmirhosseinPoolad AmirhosseinPoolad Awaiting requested review from AmirhosseinPoolad

Assignees
No one assigned
Labels
infra Project Infrastructure lang-cpp C/C++ code lang-python Python code libarchfpga Library for handling FPGA Architecture descriptions libvtrutil Odin Odin II Logic Synthesis Tool: Unsorted item VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soheilshahrouz @AlexandreSinger