Skip to content

Partial update of the code base to be consistent with rules in .clang-format file #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2025
Merged

Partial update of the code base to be consistent with rules in .clang-format file #2931

merged 2 commits into from
Mar 12, 2025

Conversation

soheilshahrouz
Copy link
Contributor

@soheilshahrouz soheilshahrouz commented Mar 12, 2025 •
edited
Loading

This PR patially updates the code base according to the .clagn-format file.

The current formatting rules remove empty lines at the end of file. I'll update .clagn-format after the format check CI test is brought back to fix this.

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code libvtrutil labels Mar 12, 2025
@soheilshahrouz soheilshahrouz requested a review from amin1377 March 12, 2025 22:04
@github-actions github-actions bot added the Odin Odin II Logic Synthesis Tool: Unsorted item label Mar 12, 2025
amin1377
amin1377 approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@amin1377 amin1377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed up to cluster_placement.h and didn’t find any changes that affect functionality. The only issue is line width, which, as discussed, will be fixed later.

AmirhosseinPoolad
AmirhosseinPoolad approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@AmirhosseinPoolad AmirhosseinPoolad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed from bottom of the changed files list to vpr/src/pack/cluster_util.cpp.

@soheilshahrouz soheilshahrouz mentioned this pull request Mar 12, 2025
Closed
@soheilshahrouz soheilshahrouz changed the title KeepEmptyLinesAtTheStartOfBlocks in clang-format Partial update of the code base to be consistent with rules in .clang-format file Mar 12, 2025
@soheilshahrouz soheilshahrouz merged commit 7059871 into master Mar 12, 2025
36 checks passed
@soheilshahrouz soheilshahrouz deleted the temp_format_try1 branch March 12, 2025 23:37
AlexandreSinger
AlexandreSinger approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @soheilshahrouz !

You read my mind about EOF lines. I am ok with removing them for this commit and adding them back after we add the CI test back in!

All of the other changes seem reasonable to me (obviously, I still think there should be a line limit; but I know I am not winning that fight lol).

This was referenced Mar 13, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amin1377 amin1377 amin1377 approved these changes

@AlexandreSinger AlexandreSinger AlexandreSinger approved these changes

@AmirhosseinPoolad AmirhosseinPoolad AmirhosseinPoolad approved these changes

Assignees
No one assigned
Labels
lang-cpp C/C++ code libvtrutil Odin Odin II Logic Synthesis Tool: Unsorted item VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soheilshahrouz @amin1377 @AlexandreSinger @AmirhosseinPoolad