[AP] Fixed Small Bug in Solver and Placer #2928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amin1377 FYI. This fixes a small bug that causes large circuits to crash in the AP flow. |
github-actions
bot
added
VPR
|
@haydar-c Can you please review this when you have a moment? No rush. |
haydar-c
reviewed
Mar 12, 2025
There was a problem hiding this comment.
Thank you @AlexandreSinger for fixing this! LGTM, this removes the bug and also makes the reconstruction flow more directed. Just a few failing AP results in strong tests.
AlexandreSinger
force-pushed
the
feature-ap-minor-bugs
branch
2 times, most recently
from
f3444cb to
7fc6b81
Compare
The solver was reserving too much space for a vector, which was causing the AP flow to crash on very large circuits. Reduced the size of the reserve to something more manageable. The Initial Placer portion of APPack had a small bug where it was ignoring the flat placement. Rewrote the section slightly to fix this issue and try to place clusters in better places.
AlexandreSinger
force-pushed
the
feature-ap-minor-bugs
branch
from
7fc6b81 to
62e9524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solver was reserving too much space for a vector, which was causing the AP flow to crash on very large circuits. Reduced the size of the reserve to something more manageable.
The Initial Placer portion of APPack had a small bug where it was ignoring the flat placement. Rewrote the section slightly to fix this issue and try to place clusters in better places.