Add a NestedNetlistRouter to enable integration with fine grained parallel router #2924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
duck2
changed the title
duck2
changed the title
vaughnbetz
requested changes
Mar 18, 2025
| std::thread thread; | ||
| std::queue<std::function<void()>> task_queue; | ||
| std::mutex queue_mutex; | ||
| std::condition_variable cv; |
There was a problem hiding this comment.
Shouldn't the name give an idea of what the condition variable controls/is used for, rather than just cv?
| std::atomic<size_t> total_tasks_queued{0}; | ||
| vtr::Timer pool_timer; // Track pool lifetime | ||
| std::atomic<size_t> active_tasks{0}; | ||
| std::mutex completion_mutex; |
There was a problem hiding this comment.
Comment these. (all the variables).
From our discussion: completion_mutex is to wait for all the tasks in the queue to finish.
| std::condition_variable completion_cv; | ||
|
|
||
| public: | ||
| thread_pool(size_t thread_count) { |
There was a problem hiding this comment.
Between the class overview and here, you need to comment how this thread pool works.
duck2
changed the title
duck2
force-pushed
the
custom-thread-pool
branch
from
dab0030 to
c6a5902
Compare
|
QoR data: custom_thread_pool_5.xlsx So |
|
Looks good. We can merge once the commenting and dead code feedback is addressed / resolved. |
duck2
force-pushed
the
custom-thread-pool
branch
from
01dbbfc to
ac3fe5b
Compare
duck2
force-pushed
the
custom-thread-pool
branch
from
ac3fe5b to
0c7800b
Compare
vaughnbetz
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBB's thread pool doesn't let us block in tasks, so we have to implement a custom thread pool if we want to integrate a parallel netlist router with a parallel connection router.