Skip to content

convert switch id check with architecture to warning instead of error #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 13, 2025
Merged

convert switch id check with architecture to warning instead of error #2855

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fd9498
convert switch id check with architecture to warning instead of error
saaramahmoudi Jan 7, 2025
64f44fb
applied VB suggestion to change the warning to a log
saaramahmoudi Jan 7, 2025
6b80092
fixed a typo
saaramahmoudi Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/librrgraph/src/io/rr_graph_uxsdcxx_serializer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ class RrGraphSerializer final : public uxsd::RrGraphBase<RrGraphContextTypes> {
}
}
if (!found_arch_name) {
report_error("Switch name '%s' not found in architecture\n", string_name.c_str());
VTR_LOG_WARN("Switch name '%s' not found in architecture\n", string_name.c_str());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we should not make this a warning, and instead just make it an info message saying something like:
"Switch name '%s' found in RR graph input from file but not in architecture file; creating it.\n", string_name.c_str());

Otherwise you are likely to get many warnings with the RR graphs you are bringing in, and they will be spurious.

}
sw->intra_tile = is_internal_sw;
sw->name = string_name;
Expand Down
Loading