-
Notifications
You must be signed in to change notification settings - Fork 414
convert switch id check with architecture to warning instead of error #2855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you summarize the testing for this case? The nightly tests aren't running automatically right now, so if you're not sure if this case is tested in the github runners you should run them manually.
Do we need any new tests?
@@ -534,7 +534,7 @@ class RrGraphSerializer final : public uxsd::RrGraphBase<RrGraphContextTypes> { | |||
} | |||
} | |||
if (!found_arch_name) { | |||
report_error("Switch name '%s' not found in architecture\n", string_name.c_str()); | |||
VTR_LOG_WARN("Switch name '%s' not found in architecture\n", string_name.c_str()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we should not make this a warning, and instead just make it an info message saying something like:
"Switch name '%s' found in RR graph input from file but not in architecture file; creating it.\n", string_name.c_str());
Otherwise you are likely to get many warnings with the RR graphs you are bringing in, and they will be spurious.
@vaughnbetz I don't think there is a need to add new tests. However, I have ran the titan benchmarks locally and made sure that nothing is going to break with this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. One nit: there should be a semicolon (or a period and new sentence if you prefer) before "creating it." i.e. "; creating it."
@vaughnbetz resolved |
This PR converts the switch error check with the architecture to a warning.
@vaughnbetz