Skip to content

[CI] Cleaned Up Artifacts and Resolved Deprecation #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexandreSinger
Copy link
Contributor

When artifacts were being saved for the regression tests, it was saving
all of the benchmarks as blif files. This is incredibly wasteful (72 MB
per regression test or around 720 MB per CI run). These tests will no
longer save .blif files as artifacts anymore. If anyone needed these
files they could generate them themselves or can add a condition to add
the exact .blif files they may need.

The CI was also always generating artifacts (at least for the nightly
tests) even when the run was cancelled. Made it so the artifacts are
only saved if the run is not cancelled. This would mean an artifact is
generated if the run succeeds or fails.

save-output was deprecated. Resolved. See:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
image

When artifacts were being saved for the regression tests, it was saving
all of the benchmarks as blif files. This is incredibly wasteful (72 MB
per regression test or around 720 MB per CI run). These tests will no
longer save .blif files as artifacts anymore. If anyone needed these
files they could generate them themselves or can add a condition to add
the exact .blif files they may need.

The CI was also always generating artifacts (at least for the nightly
tests) even when the run was cancelled. Made it so the artifacts are
only saved if the run is not cancelled. This would mean an artifact is
generated if the run succeeds or fails.
@AlexandreSinger
Copy link
Contributor Author

AlexandreSinger commented Jun 7, 2024

@soheilshahrouz Are you ok with this change with when artifacts are saved? This change will make it so when a run in cancelled it will not save the artifacts, but it will save the artifacts if the run succeeds or fails. I anticipate there will be more cancelled runs in the future, so this will prevent saving artifacts when they are not needed.

@github-actions github-actions bot added the infra Project Infrastructure label Jun 7, 2024
@AlexandreSinger AlexandreSinger force-pushed the feature-ci-artifacts-revisited branch from 3efdaaf to 4878db9 Compare June 7, 2024 20:01
@AlexandreSinger
Copy link
Contributor Author

@vaughnbetz This has passed CI. I have verified that the artifacts are no longer being collected on cancellation and the overall size of the artifacts decreased from 1000 MBs per run to 250 MBs per run. 120 MBs is being taken up from vtr_reg_nightly_test1, so if we have issues in the future we can see what we need to be collecting for that test.

I have also verified that the deprecation warning is now gone.

@vaughnbetz vaughnbetz merged commit 6e85a77 into verilog-to-routing:master Jun 11, 2024
53 checks passed
@AlexandreSinger AlexandreSinger deleted the feature-ci-artifacts-revisited branch July 16, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Project Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants