Merge pull request #2597 from AlexandreSinger/feature-ci-artifacts-revisited

[CI] Cleaned Up Artifacts and Resolved Deprecation

Author: vaughnbetz

.github/workflows/containers.yml

@@ -46,7 +46,7 @@ jobs:
         id: generate
         run: |
           REPO='${{ github.repository }}'
-          echo "::set-output name=image::ghcr.io/${REPO,,}/ubuntu/focal/build"
+          echo "image=ghcr.io/${REPO,,}/ubuntu/focal/build" >> $GITHUB_OUTPUT
 
       - name: ⛴️ Build container image
         run: docker build -t ${{ steps.generate.outputs.image }} -f Dockerfile .

.github/workflows/test.yml

@@ -96,9 +96,10 @@ jobs:
         NUM_CORES: ${{ matrix.cores }}
 
     - name: Upload test results
-      # We always want the test results to be uploaded, even when cancelled.
+      # If the job was not cancelled, we want to save the result (this includes
+      # when the job fails). See warning here:
       # https://docs.github.com/en/actions/learn-github-actions/expressions#always
-      if: ${{ always() }}
+      if: ${{ !cancelled() }}
       # TODO: This runnner is running on a self-hosted CPU. In order to upgrade
       #       to v4, need to upgrade the machine to support node20.
       uses: actions/upload-artifact@v3
@@ -285,17 +286,19 @@ jobs:
         ./run_reg_test.py ${{ matrix.suite }} -show_failures -j2
 
     - name: Upload regression run files
+      if: ${{ !cancelled() }}
       uses: actions/upload-artifact@v4
       with:
         name: ${{matrix.name}}_run_files
         path: |
           vtr_flow/**/*.out
-          vtr_flow/**/*.blif
+          # vtr_flow/**/*.blif  # Removed since it was taking too much space and was hardly used.
           vtr_flow/**/*.p
           vtr_flow/**/*.net
           vtr_flow/**/*.r
 
     - name: Upload regression results
+      if: ${{ !cancelled() }}
       uses: actions/upload-artifact@v4
       with:
         name: ${{matrix.name}}_results