Fix: Address warnings in Koios 3D architectures and add additional test #2472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
VB: please add a comment in the arch file that the empty blocks are modelling TSVs. They have power or gnd comments, but that is still a bit mysterious without more detail. |
amin1377
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Koios 3D architectures, there are blocks of the type "tsv_hole" that are not connected to any channel. However, during the construction of the router lookahead, warnings are generated because the pins on these blocks are not connected to any channel. To resolve this issue, the type of these blocks has been changed to "empty."
Additionally, an extra test has been included for the 3D architecture. When placement bounding box is set to"auto" mode, the Titan 3D architecture utilizes per-layer bounding boxes. The newly added test will assess the same architecture with a cube bounding box.