Skip to content

Fix Segment Usage Message #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 6, 2023
Merged

Fix Segment Usage Message #2408

merged 12 commits into from
Oct 6, 2023

Conversation

amin1377
Copy link
Contributor

@amin1377 amin1377 commented Oct 4, 2023

This PR addresses issue#2399

Sample output:
Screenshot from 2023-10-04 15-11-38
Screenshot from 2023-10-04 15-13-06

@github-actions github-actions bot added the VPR VPR FPGA Placement & Routing Tool label Oct 5, 2023
@WhiteNinjaZ
Copy link
Contributor

WhiteNinjaZ commented Oct 5, 2023 •
edited
Loading

Superb, this looks great and should fix the issue.

vaughnbetz
vaughnbetz reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK; slightly odd to use both a map and a vector (two different paradigms for storing the data per length/axis). Could just use a map or maps, and get rid of the "seen_lengths" set. Your call if you want to change it or not.

@vaughnbetz
Copy link
Contributor

Looks good. Will merge once CI finishes.

@vaughnbetz vaughnbetz merged commit 15c5340 into master Oct 6, 2023
@vaughnbetz vaughnbetz deleted the fix_segment_occ_msg branch October 6, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaughnbetz vaughnbetz vaughnbetz left review comments

Assignees
No one assigned
Labels
VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amin1377 @WhiteNinjaZ @vaughnbetz