Skip to content

Segment Usage by Type does not return the values that the title would suggest it should #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WhiteNinjaZ opened this issue Sep 22, 2023 · 1 comment
Assignees

Comments

@WhiteNinjaZ
Copy link
Contributor

WhiteNinjaZ commented Sep 22, 2023

In vpr.out one of the reports is "Segment usage by type (Index)". I would expect from the description/title (usage by type (index)) that this report should give the percentage of segments of each type in the RR that are actually used in the net-list for the design. However, Looking at the code (shown bellow) it appears that what is actually happening is that each wire of a given length being used in the net list is being counted up and that this value is being used to give a percentage of wires used. This creates an issue if wires with different properties have the same length and a user wants to see how many wires with specific properties are used in the design.

Where the Code Producing this issue can be found

The following image is lines 103-122 of ${VPR_ROOT}/vpr/src/route/segment_stats.cpp:
image

Expected Behaviour

The description/title of this section should either reflect that we are looking at wire counts by length and index or the code base should be changed to count wire usage using the indexes of those wires in the RR.

Also the title of this section should probably be changed to Segment Occupancy By type since Usage could be interpreted as occurrences (which is different).

@WhiteNinjaZ WhiteNinjaZ changed the title Segment Usage by Type does not return the values that the description would suggest it should Segment Usage by Type does not return the values that the title would suggest it should Sep 22, 2023
@amin1377 amin1377 self-assigned this Sep 24, 2023
@amin1377
Copy link
Contributor

amin1377 commented Oct 4, 2023

@WhiteNinjaZ : Whenever you have time, please take a look at the PR related to this issue and let me know if it would solve the problem.

@amin1377 amin1377 closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants