Skip to content

Clean up and Document Placement #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 14, 2023
Merged

Clean up and Document Placement #2317

Changes from 5 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9e15932
placer seed was printed before it was set
saaramahmoudi May 17, 2023
cbb366a
make format
saaramahmoudi May 17, 2023
e975b36
removed the extra seed setup before placement
saaramahmoudi May 18, 2023
88f3efc
Merge branch 'setup_placer_seed' of https://github.com/verilog-to-rou…
saaramahmoudi May 18, 2023
14b2bd6
Merge branch 'master' into setup_placer_seed
saaramahmoudi May 19, 2023
06aa4b4
Merge branch 'master' into setup_placer_seed
saaramahmoudi May 24, 2023
b06848e
Merge branch 'master' into setup_placer_seed
saaramahmoudi May 25, 2023
e09a152
Merge branch 'master' into setup_placer_seed
saaramahmoudi May 26, 2023
2f55d1f
Merge branch 'master' into setup_placer_seed
saaramahmoudi May 31, 2023
1bc2039
removed todo for PlacerOpts documentation
saaramahmoudi Jun 2, 2023
c56d7b8
updated command line documentation for RLPlace1/2 options
saaramahmoudi Jun 2, 2023
71e6c9a
added noc command-line options to doc
saaramahmoudi Jun 2, 2023
7da4ef5
clean up the NoC documentations
saaramahmoudi Jun 2, 2023
3ed40ee
fix some traffic flow typos in NoC benchmarks
saaramahmoudi Jun 2, 2023
8b761d3
applied PR suggestions for placer options
saaramahmoudi Jun 2, 2023
1098c02
Merge branch 'master' into setup_placer_seed
saaramahmoudi Jun 6, 2023
f53cad4
moved noc router connection list print to arch.echo file
saaramahmoudi Jun 8, 2023
f4b3d2f
make format
saaramahmoudi Jun 8, 2023
9c8d32a
Merge branch 'master' into setup_placer_seed
saaramahmoudi Jun 12, 2023
d88b444
Merge branch 'master' into setup_placer_seed
saaramahmoudi Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vpr/src/base/SetupVPR.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ void SetupVPR(const t_options* Options,
vtr::out_file_prefix = Options->out_file_prefix;

/* Set seed for pseudo-random placement, default seed to 1 */
PlacerOpts->seed = Options->Seed;
vtr::srandom(PlacerOpts->seed);

{
Expand Down Expand Up @@ -666,6 +665,8 @@ static void SetupPlacerOpts(const t_options& Options, t_placer_opts* PlacerOpts)
PlacerOpts->place_constraint_subtile = Options.place_constraint_subtile;
PlacerOpts->floorplan_num_horizontal_partitions = Options.floorplan_num_horizontal_partitions;
PlacerOpts->floorplan_num_vertical_partitions = Options.floorplan_num_vertical_partitions;

PlacerOpts->seed = Options.Seed;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please check if we can remove the PlacerOpts->seed line from the placer now (should be able to). Best to remove it in that case to avoid confusion.
  2. ToDo: document:
  • place_cost_exp: wiring cost is divided by the average channel width over a net's bounding box taken to this exponent. Default: 1. Only impacts devices with different channel widths in different directions or regions.
  1. Document RLPlace options if they aren't already.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saaramahmoudi : placerOpts->seed setting line is now removed from the placer. If the two documentation updates can be made we can merge this. Or if that will take a while please create an issue to track them and I'll merge this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaughnbetz will fix the documentation today and will mention you when it is done.

}

static void SetupAnalysisOpts(const t_options& Options, t_analysis_opts& analysis_opts) {
Expand Down