-
Notifications
You must be signed in to change notification settings - Fork 415
Clean up and Document Placement #2317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9e15932
cbb366a
e975b36
88f3efc
14b2bd6
06aa4b4
b06848e
e09a152
2f55d1f
1bc2039
c56d7b8
71e6c9a
7da4ef5
3ed40ee
8b761d3
1098c02
f53cad4
f4b3d2f
9c8d32a
d88b444
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -267,7 +267,6 @@ void SetupVPR(const t_options* Options, | |
vtr::out_file_prefix = Options->out_file_prefix; | ||
|
||
/* Set seed for pseudo-random placement, default seed to 1 */ | ||
PlacerOpts->seed = Options->Seed; | ||
vtr::srandom(PlacerOpts->seed); | ||
|
||
{ | ||
|
@@ -600,7 +599,6 @@ static void SetupPlacerOpts(const t_options& Options, t_placer_opts* PlacerOpts) | |
PlacerOpts->inner_loop_recompute_divider = Options.inner_loop_recompute_divider; | ||
PlacerOpts->quench_recompute_divider = Options.quench_recompute_divider; | ||
|
||
//TODO: document? | ||
PlacerOpts->place_cost_exp = 1; | ||
|
||
PlacerOpts->td_place_exp_first = Options.place_exp_first; | ||
|
@@ -629,7 +627,6 @@ static void SetupPlacerOpts(const t_options& Options, t_placer_opts* PlacerOpts) | |
PlacerOpts->delay_model_type = Options.place_delay_model; | ||
PlacerOpts->delay_model_reducer = Options.place_delay_model_reducer; | ||
|
||
//TODO: document? | ||
PlacerOpts->place_freq = PLACE_ONCE; /* DEFAULT */ | ||
|
||
PlacerOpts->post_place_timing_report_file = Options.post_place_timing_report_file; | ||
|
@@ -666,6 +663,8 @@ static void SetupPlacerOpts(const t_options& Options, t_placer_opts* PlacerOpts) | |
PlacerOpts->place_constraint_subtile = Options.place_constraint_subtile; | ||
PlacerOpts->floorplan_num_horizontal_partitions = Options.floorplan_num_horizontal_partitions; | ||
PlacerOpts->floorplan_num_vertical_partitions = Options.floorplan_num_vertical_partitions; | ||
|
||
PlacerOpts->seed = Options.Seed; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @saaramahmoudi : placerOpts->seed setting line is now removed from the placer. If the two documentation updates can be made we can merge this. Or if that will take a while please create an issue to track them and I'll merge this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @vaughnbetz will fix the documentation today and will mention you when it is done. |
||
} | ||
|
||
static void SetupAnalysisOpts(const t_options& Options, t_analysis_opts& analysis_opts) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know @Srivat97 has a PR that's about to land that documents the NoC options too. @Srivat97 : I suggest landing yours and then Sara can enhance any NoC documentation that doesn't capture everything she has here.