-
Notifications
You must be signed in to change notification settings - Fork 416
Floorplanning legend #2147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Floorplanning legend #2147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaughnbetz
requested changes
Sep 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Minor changes.
Also add to the documentation.
@jmah76 : is this ready to merge now? Seems like everything is ready ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a legend of all partitions in a constraints file in the VPR GUI. Entries in the legend are partition names with the number of primitives contained. Clicking on a partition on the menu highlights it.
(Note: Might need to merge in PR #2134 first)

Testing
Checked multiple architechtures
Ran vpr/vpr (insert architecture here) vtr_flow/benchmarks/blif/tseng.blif --route_chan_width 100 --read_vpr_constraints constraints.xml then vpr/vpr (insert architecture here) vtr_flow/benchmarks/blif/tseng.blif --route_chan_width 100 --read_vpr_constraints constraints.xml --analysis --disp on with EArch.xml, k6_frac_N10_40nm.xml, and k6_frac_N10_mem32K_40nm.xml. All draw the partitions properly and their atoms inside their respective partitions properly.
Lots of partitions:
Created a constraints file with an arbitarily large number or partitions to ensure the legend still works with many partitions.