Draw Partitions for Floorplanning #2134
Conversation
|
With respect to Valgrind: Running the same command on draw_placement_constraint gives this output: Without graphics (i.e. |
{{ message }}
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Given a constraints file, VPR can now:
Tests
More partitions than number of colours available:
Number of possible colours for partitions was limited to 5 colours. Number of partitions in the constraint file was set to 9. Having moe partitions than colours available does not crash the program. Pictures above.
Checking different architectures:
Ran
vpr/vpr (insert architecture here) vtr_flow/benchmarks/blif/tseng.blif --route_chan_width 100 --read_vpr_constraints constraints.xmlthenvpr/vpr (insert architecture here) vtr_flow/benchmarks/blif/tseng.blif --route_chan_width 100 --read_vpr_constraints constraints.xml --analysis --disp onwith EArch.xml, k6_frac_N10_40nm.xml, and k6_frac_N10_mem32K_40nm.xml. All draw the partitions properly and their atoms inside their respective partitions properly.Valgrind
Even on the master branch, running Valgrind with graphics results in memory leaks. Because of this, I'm not sure how to test if I added more memory leaks. Valgrind was run with the command
valgrind --leak-check=full --suppressions=./vpr/valgrind.supp --suppressions=/usr/share/glib-2.0/valgrind/glib.supp --suppressions /usr/share/gtk-3.0/valgrind/gtk.supp vpr/vpr (insert architecture here) vtr_flow/benchmarks/blif/tseng.blif --route_chan_width 100 --read_vpr_constraints constraints.xml --analysis --disp on. Without graphics it produces no leaks.