Handle Multiplication Operation Output Size #2013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdamghan
added
kokoro:force-run
Yosys+Odin-II
|
@aman26kbm this should fix the failure resulting from unmatched multiplication output size. Would you mind checking a look at it? |
|
Thanks, @sdamghan . I verified this fix with my testcase. Please go ahead and merge. :) |
|
Sounds good, will update with the master branch and merge it. |
…of inputs Signed-off-by: Seyed Alireza Damghani <[email protected]>
sdamghan
force-pushed
the
yosys_odin_mul_out
branch
from
843a5df to
d09ba2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Seyed Alireza Damghani [email protected]
Description
Padding the multiplication output port if it's size is less than the sum of both input ports
Related Issue
#2007
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: