Update cluster gains once per cluster #1886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gain and mark_and_update_partial_gain routines
|
QoR comparison before and after gain update changes: No significant changes in pack time. |
|
@sfkhalid : there are warnings in the code that need to be fixed to pass CI. |
Yep, I'm looking into fixing those now. |
…ng null pointer doesn't appear
|
QoR Results Comparisons: |
sfkhalid
commented
Oct 28, 2021
sfkhalid
commented
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently during clustering the gain values are updated once for each level in a t_pb - from the root node down to the child node. However, the gain information only needs to be stored for the root pb, - the gain stored for the child pbs is never used. This pull request fixes the excess updates done during clustering.