fix_track_memory_usage #1838
Merged
fix_track_memory_usage #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he argument, also made default value of argument true
|
Thanks @sfkhalid . Code looks good; will merge once CI goes green. |
|
Thanks; change looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in this pull request is the same as PR #1827. Added the change to a new branch because I wasn't able to checkout the other remote branch as it was on a fork off of the main remote repo verilog-to-routing/vtr-verilog-to-routing.
The original change was to make sure the runner looks at the argument track_memory_usage to see whether memory tracking should be turned on or off, instead of just always making it on.
An additional change was made that was requested in a comment on #1827 - the default value of track_memory_usage was set to "True" so that track_memory_usage is always on unless the argument specifies that it should be off.
Types of changes