-
Notifications
You must be signed in to change notification settings - Fork 415
Remove redundant vtr_reg_strong run on CI #1852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I just double checked. It seems that the VTR strong tests (without sanitizer) are indeed run on both Github Actions and Kokoro. |
@sfkhalid Just to be clear we want to remove this kokoro configuration. https://github.com/verilog-to-routing/vtr-verilog-to-routing/blob/master/.github/kokoro/presubmit/strong.cfg Once you confirm I can disable it from the Google side, and then we can remove the file in this repo. |
Yes, this is the one we want to remove. |
You can remove strong.cfg from the continuous runs as well as they are also run by a github runner (I just confirmed that). So that is: |
To give a clear spec, there are two configurations to remove: |
I believe this is now done with the removal of Kokoro entirely. |
Uh oh!
There was an error while loading. Please reload this page.
Currently the CI runs strong 3 times - twice on github actions (one with the pull request configuration, one with the push configuration, and once on kokoro. The runs on kokoro and github actions push seem to be running strong on the same code (the last commit that was pushed to the branch).
For example, looking at PR #1838, we can see that both the github actions push run and the kokoro run are on commit dff03397. This can be seen by going to details->invocation details->git_commit (for kokoro) and details->run_actions/checkout@v2 (for github actions push).
The github actions pull request run is on a different commit ca8879.
Proposed Behaviour
The proposed behaviour is to stop doing the strong kokoro run, since it is already covered by the github actions strong push run.
Possible Solution
Remove the strong.cfg file from the .github/kokoro/presubmit directory
The text was updated successfully, but these errors were encountered: