Koios benchmarks (2nd PR) #1787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eparate include file. 2. Updated task files to include this new include file. 3. Added new tests that run these benchmarks without the complex_dsp macro defined. 4. Updated documentation to cleanly describe the usage of these benchmarks (including measuring QoR)
github-actions
bot
added
docs
|
Tagging @vaughnbetz to please review the changes. |
vaughnbetz
requested changes
Jun 23, 2021
vtr_flow/tasks/regression_tests/vtr_reg_nightly_test4/koios_multi_arch/config/config.txt
Outdated
Show resolved
Hide resolved
vtr_flow/tasks/regression_tests/vtr_reg_nightly_test4/koios_no_complex_dsp/config/config.txt
Outdated
Show resolved
Hide resolved
vtr_flow/tasks/regression_tests/vtr_reg_strong/koios_no_complex_dsp/config/config.txt
Outdated
Show resolved
Hide resolved
vtr_flow/tasks/regression_tests/vtr_reg_weekly/koios_no_complex_dsp/config/config.txt
Outdated
Show resolved
Hide resolved
Also fixing a mistake in some no_complex_dsp tasks. By mistake the complex_dsp_include file was included.
|
Thanks for the review, @vaughnbetz . |
|
OK, waiting for the new golden results and then will merge. |
Also updating the QoR related documentation to clarify and improve the commands.
|
Pushed a commit with the golden results of no_complex_dsp weekly regression. No other commit is pending now. So, the changes can be merged after all the checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the second PR for Koios benchmarks. The main changes in this PR are:
Related Issue
This PR contains changes pending from the first PR: #1753.
This PR also contains changes suggested in the issue: #1782.
Types of changes
Checklist: