-
Notifications
You must be signed in to change notification settings - Fork 415
Add Koios benchmark QoR example to the vtr developer guide, and add koios to CI #1782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for filing this, Vaughn. I will add to task #2. I need to add protection of benchmarks without the "`define complex_dsp". And I need to update the documentation to mention how to run benchmarks with and without complex_dsp (the new include file method). I will work on these within next week. |
I've created a new PR which includes the changes for task #1 mentioned in this issue. @ArashAhmadian , can you please guide me on what changes to make changes for task #2? I'll make those changes and push them to this new PR I've created. [Edit: Fix typo in task number] |
@aman26kbm Sure, do you mean changes to add vtr_reg_nightly_test4 to CI? Your previous PR actually added the .cfg file and made the necessary changes in vtr_test.sh so I think everything is good from our side. |
Right. That's great. (Sorry for the typo in my previous comment. I meant to point to task #2 in the question I asked :P. Fixing it now) |
I don't see them being run. I think @mithro needs to add the configs on the Google side of things for them to start running. |
Ok. Thanks. We can discuss this with @mithro in this week's VTR meeting on Thursday. |
Sounds good. |
@aman26kbm What's your email? I am drafting the email to Arnaud and I can put you on it. |
Aman is at [email protected] |
This issue has been inactive for a year and has been marked as stale. It will be closed in 15 days if it continues to be stale. If you believe this is still an issue, please add a comment. |
This has been completed; marking closed. |
The Koios benchmarks have been integrated into the vtr repo, but to have the most impact, we should do two more things:
Add a short description (and links to the benchmark README) to the VTR developer guide under the QoR Collection section: https://docs.verilogtorouting.org/en/latest/dev/developing/#collecting-qor-measurements
It should come after the Titan benchmarks (or maybe after the VTR benchmarks if that flows better as they go all the way through odinII ...)_ and have a similar style.
The vtr_reg_nightly4 suite that runs them should be added to CI. @ArashAhmadian can work with you to make the necessary changes and pin Tim Ansell to make the eventual google-side changes.
The text was updated successfully, but these errors were encountered: