CMake: append to LINK_FLAGS instead of replacing them #1646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With
INTERPROCEDURAL_OPTIMIZATION
/LTO enabled, LDFLAGS from the environment are ignored.Related Issue
N/A
Motivation and Context
CMake takes the default linker flags from the LDFLAGS environment variable and initializes the targets'
LINK_FLAGS
with it. Ifset_target_property()
is used to overwrite a target'sLINK_FLAGS
, these initial linker flags from the environment are lost.How Has This Been Tested?
Types of changes
Checklist: