ODIN_II: Changes to fix coverity scan errors #1565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit addresses several errors CID 212805: API usage errors (PRINTF_ARGS) Related to verilog-to-routing#1496 Signed-off-by: Georgiy Krylov <[email protected]>
|
lgtm! once kokoro passes, i can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit addresses several errors
CID 212805: API usage errors (PRINTF_ARGS)
Related to #1496
Description
The printf function used as part of the odin_error, was not even treated with a warning, while was caught as coverity scan.
Related Issue
Motivation and Context
Makes the code cleaner
How Has This Been Tested?
Executed make test in ODIN_II directory
Types of changes
Checklist: