-
Notifications
You must be signed in to change notification settings - Fork 415
Add extended lookahead map followup #1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extended lookahead map followup #1536
Conversation
7e4b00b
to
5a7d243
Compare
@acomidi: let me know when this is ready for review. Also, it appears to include all commits for the extended lookahead map; can you rebase so only the new commits for this change are visible (or let me know what subset of commits to view)? Finally, if you can note which remaining issues / comments are addressed by this PR that would be good. I can see the clamp function has been moved and it looks like more RRNodeIDs are being used, but a list would be helpful. |
5a7d243
to
51227f3
Compare
@vaughnbetz I have applied the required changes to have lookahead methods get as inputs RRNodeIDs. There is also the assertion addition to the get_median_entry and a missing comment requested in the previous extended lookahead PR. |
Thanks for the changes, and they look good. But there are some regtest failures (a bunch with reorder_rr_nodes, but they're not hte only ones) and they look like crashes, not QoR changes. |
Signed-off-by: Alessandro Comodi <[email protected]>
Signed-off-by: Alessandro Comodi <[email protected]>
Signed-off-by: Alessandro Comodi <[email protected]>
51227f3
to
ff458ff
Compare
Signed-off-by: Alessandro Comodi <[email protected]>
ff458ff
to
a5cc9ef
Compare
Signed-off-by: Alessandro Comodi <[email protected]>
@vaughnbetz CI went green on all tests now. I have also added a fix that should solve the coverty scan issue with the seg_count_ member of the cost map. Unsure why there is a double Travis CI though |
Yes, the second travis CI seems hung, but looking at the individual tests in it they look like they passed anyway. Strange. |
Description
Followup of #1449.
This PR is a followup to solve some outstanding comments on the lookahead extended map that require some more work.
To not have to wait a full CI build once again, these changes are applied to this followup PR
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: