Skip to content

Add extended lookahead map followup #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

acomodi
Copy link
Collaborator

@acomodi acomodi commented Sep 11, 2020

Description

Followup of #1449.

This PR is a followup to solve some outstanding comments on the lookahead extended map that require some more work.
To not have to wait a full CI build once again, these changes are applied to this followup PR

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@probot-autolabeler probot-autolabeler bot added build Build system lang-cpp C/C++ code lang-make CMake/Make code libvtrutil tests VPR VPR FPGA Placement & Routing Tool VTR Flow VTR Design Flow (scripts/benchmarks/architectures) labels Sep 11, 2020
@acomodi acomodi force-pushed the add-extended-lookahead-map-followup branch from 7e4b00b to 5a7d243 Compare September 11, 2020 17:14
@vaughnbetz
Copy link
Contributor

@acomidi: let me know when this is ready for review. Also, it appears to include all commits for the extended lookahead map; can you rebase so only the new commits for this change are visible (or let me know what subset of commits to view)? Finally, if you can note which remaining issues / comments are addressed by this PR that would be good. I can see the clamp function has been moved and it looks like more RRNodeIDs are being used, but a list would be helpful.

@acomodi acomodi force-pushed the add-extended-lookahead-map-followup branch from 5a7d243 to 51227f3 Compare September 14, 2020 16:23
@acomodi
Copy link
Collaborator Author

acomodi commented Sep 14, 2020

@vaughnbetz I have applied the required changes to have lookahead methods get as inputs RRNodeIDs.

There is also the assertion addition to the get_median_entry and a missing comment requested in the previous extended lookahead PR.

@acomodi acomodi requested a review from vaughnbetz September 14, 2020 16:24
@vaughnbetz
Copy link
Contributor

Thanks for the changes, and they look good. But there are some regtest failures (a bunch with reorder_rr_nodes, but they're not hte only ones) and they look like crashes, not QoR changes.

@acomodi acomodi force-pushed the add-extended-lookahead-map-followup branch from 51227f3 to ff458ff Compare September 15, 2020 09:17
@acomodi acomodi force-pushed the add-extended-lookahead-map-followup branch from ff458ff to a5cc9ef Compare September 15, 2020 09:46
@acomodi
Copy link
Collaborator Author

acomodi commented Sep 16, 2020

@vaughnbetz CI went green on all tests now. I have also added a fix that should solve the coverty scan issue with the seg_count_ member of the cost map.

Unsure why there is a double Travis CI though

@vaughnbetz
Copy link
Contributor

Yes, the second travis CI seems hung, but looking at the individual tests in it they look like they passed anyway. Strange.

@vaughnbetz vaughnbetz merged commit 884eccd into verilog-to-routing:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system lang-cpp C/C++ code lang-make CMake/Make code libvtrutil tests VPR VPR FPGA Placement & Routing Tool VTR Flow VTR Design Flow (scripts/benchmarks/architectures)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants