Connection box map WIP branch #546
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acomodi Can you cherry pick the following commits onto |
litghost
reviewed
Sep 14, 2020
litghost
reviewed
Sep 14, 2020
litghost
reviewed
Sep 14, 2020
litghost
reviewed
Sep 14, 2020
| int num_switches = 0; | ||
| short buffered = UNDEFINED; | ||
| calculate_average_switch(inode, avg_switch_R, avg_switch_T, avg_switch_Cinternal, num_switches, buffered); |
There was a problem hiding this comment.
FYI, by not calling calculate_average_switch we are masking an assertion failure that occurs on upstream VTR. I'm fine with this so we can merge a new master+wip for now, just mentioning it again.
acomodi
force-pushed
the
wip/connection_box_lookahead_map
branch
2 times, most recently
from
ac20300 to
1539484
Compare
Signed-off-by: Alessandro Comodi <[email protected]>
Signed-off-by: Keith Rothman <[email protected]>
Signed-off-by: Keith Rothman <[email protected]>
Signed-off-by: Keith Rothman <[email protected]>
Signed-off-by: Keith Rothman <[email protected]>
- New sampling method for connection box lookahead map. - New spiral hole filling algorithm - Use a lightweight version of PQ_Entry (PQ_Entry_Lite) - Use maps in run_dijkstra() - Move context of router_lookahead_map_utils inside of util namespace. Signed-off-by: Dusty DeWeese <[email protected]> Signed-off-by: Keith Rothman <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Expand base_cost too. The delay and base cost matricies are independent, so should be expanded and filled independently. Signed-off-by: Keith Rothman <[email protected]> Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]>
Signed-off-by: Dustin DeWeese <[email protected]>
Signed-off-by: Keith Rothman <[email protected]>
Signed-off-by: Dustin DeWeese <[email protected]>
Signed-off-by: Dustin DeWeese <[email protected]>
Signed-off-by: Dustin DeWeese <[email protected]>
Signed-off-by: Keith Rothman <[email protected]>
- addressed review comments Signed-off-by: Alessandro Comodi <[email protected]>
Signed-off-by: Henner Zeller <[email protected]>
Signed-off-by: Dusty DeWeese <[email protected]> Signed-off-by: Keith Rothman <[email protected]>
Before on the A200T: > Computing connection box lookahead map took 31769.29 seconds (max_rss 45671.6 MiB, delta_rss +14486.3 MiB) After on the A200T: > Computing connection box lookahead map took 16791.79 seconds (max_rss 40113.6 MiB, delta_rss +8895.9 MiB) Signed-off-by: Keith Rothman <[email protected]>
Signed-off-by: Keith Rothman <[email protected]>
Signed-off-by: Keith Rothman <[email protected]>
Signed-off-by: Alessandro Comodi <[email protected]>
Signed-off-by: Keith Rothman <[email protected]>
…on order. Signed-off-by: Keith Rothman <[email protected]>
…on order. Signed-off-by: Keith Rothman <[email protected]>
Signed-off-by: Alessandro Comodi <[email protected]>
acomodi
force-pushed
the
wip/connection_box_lookahead_map
branch
from
1539484 to
932fda8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the new connection box lookahead map
wip/branch that has been rebased against master.Given that there is conflicting code with the extended map, and the fact that the connection boxes made it non-trivial to adapt the code for this wip branch, I have opted to keep all the connection box code as contained as possible, which results in a slight code duplication regarding the two extended map and conection box map lookaheads methods.
This branch has been added to #545