Skip to content

Fix timing cost consistency check bug #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Fix timing cost consistency check bug #1417

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
978d8ef
Fix timing cost consistency check bug: shouldn't have criticality upd…
Bill-hbrhbr Jul 10, 2020
74c4250
Make format
Bill-hbrhbr Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions vpr/src/place/timing_place.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,12 @@ void PlacerCriticalities::update_criticalities(const SetupTimingInfo* timing_inf
if (INCR_UPDATE_CRITICALITIES) {
cluster_pins_with_modified_criticality_.clear();
if (crit_exponent != last_crit_exponent_) {
//Criticality exponent changed, must re-calculate *all* criticalties
auto pins = clb_nlist_.pins();
cluster_pins_with_modified_criticality_.insert(pins.begin(), pins.end());
//Criticality exponent changed, must re-calculate criticalities for *all* sink pins
for (ClusterNetId net_id : clb_nlist_.nets()) {
for (ClusterPinId pin_id : clb_nlist_.net_sinks(net_id)) {
cluster_pins_with_modified_criticality_.insert(pin_id);
}
}

//Record new criticality exponent
last_crit_exponent_ = crit_exponent;
Expand Down Expand Up @@ -68,8 +71,11 @@ void PlacerCriticalities::update_criticalities(const SetupTimingInfo* timing_inf
}
} else {
//Non-incremental: all pins and nets need updating
auto pins = clb_nlist_.pins();
cluster_pins_with_modified_criticality_.insert(pins.begin(), pins.end());
for (ClusterNetId net_id : clb_nlist_.nets()) {
for (ClusterPinId pin_id : clb_nlist_.net_sinks(net_id)) {
cluster_pins_with_modified_criticality_.insert(pin_id);
}
}
}

//Update the effected pins
Expand Down