Skip to content

Deal with Swiftbar change #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Deal with Swiftbar change #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88059a2
Deal with Swiftbar change
unixorn Dec 22, 2021
02543b9
Update superlinter configuration
unixorn Dec 22, 2021
08f6612
Fix version in About menu
unixorn Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/superlinter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
# Run Linter against code base #
################################
- name: Lint Code Base
uses: github/super-linter@v3
uses: github/super-linter@v4
env:
VALIDATE_ALL_CODEBASE: false
DEFAULT_BRANCH: main
Expand Down
6 changes: 5 additions & 1 deletion Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,8 @@

## 1.3.1

- Add `/opt/homebrew/bin` to the plugin's `$PATH` when it exists and is a directory.
- Add `/opt/homebrew/bin` to the plugin's `$PATH` when it exists and is a directory.

## 1.3.2

- Swiftbar started capturing `stderr` in addition to `stdout`, causing log messages to spam the menu bar. Default to log level critical so we don't spam log messages (that no one was seeing anyway) except when we're testing.
10 changes: 5 additions & 5 deletions lima-plugin
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# Copyright 2021, Joe Block <[email protected]>
#
# <xbar.title>Lima Control</xbar.title>
# <xbar.version>v1.0</xbar.version>
# <xbar.version>v1.3.2</xbar.version>
# <xbar.author>Joe Block</xbar.author>
# <xbar.author.github>unixorn</xbar.author.github>
# <xbar.desc>Control Lima VM</xbar.desc>
Expand Down Expand Up @@ -34,7 +34,7 @@ RUNNING_VM_COLOR = "#29cc00"
# Stopped VM color (default red)
STOPPED_VM_COLOR = "#ff0033"

VERSION = "1.3.1"
VERSION = "1.3.2"


def logSetup(level: str = "INFO"):
Expand Down Expand Up @@ -72,7 +72,7 @@ def parseCLI():
type=str.upper,
help="set log level",
choices=["DEBUG", "INFO", "ERROR", "WARNING", "CRITICAL"],
default="INFO",
default="CRITICAL",
)
parser.add_argument(
"--vm", "--virtual-machine", type=str, help="Which vm to use", default="default"
Expand Down Expand Up @@ -325,7 +325,7 @@ def imageOps(action: str, image: str, vm: str = "default"):
:param str image: What image to do the action on
:param str vm: Which VM is the image in?
"""
logging.critical("imageOps")
logging.info("imageOps")
logging.info("action: %s" % action)
logging.info("image: %s" % image)
logging.info("vm: %s" % vm)
Expand Down Expand Up @@ -371,7 +371,7 @@ def vmOps(action: str, vm: str = "default"):
:param str action: What action to run - should be start or stop
:param str vm: Name of VM to act on
"""
logging.critical("vmOps")
logging.info("vmOps")
logging.debug("action: %s" % action)
logging.debug("vm: %s" % vm)

Expand Down