Skip to content

Deal with Swiftbar change #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Deal with Swiftbar change #27

merged 3 commits into from
Dec 22, 2021

Conversation

unixorn
Copy link
Owner

@unixorn unixorn commented Dec 22, 2021

Description

Swiftbar now is capturing STDERR in addition to STDOUT, which made all the logging info get spammed to the menubar.

We now default to log level CRITICAL - log output is only necessary during debugging, so this stifles all log output during normal runs by Swiftbar and Xbar.

Closes #26

Type of changes

Bugfix to cope with Swiftbar changes.

Checklist

  • All new and existing tests pass.
  • Any added/updated scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh and #!/bin/bash are allowed exceptions)
  • Added/updated scripts are marked executable
  • Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No end-user should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have confirmed that the link(s) in my PR are valid.

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Swiftbar now is capturing `stderr` in addition to `stdout`, which made
all the logging info get spammed to the menubar.

We now default to log level critical - log output is only necessary
during debugging, so stifle all log output during normal runs by
Swiftbar and Xbar.

Closes #26

Signed-off-by: Joe Block <[email protected]>
Update superlinter to use @v4

Signed-off-by: Joe Block <[email protected]>
Signed-off-by: Joe Block <[email protected]>
@unixorn unixorn merged commit acf59bf into main Dec 22, 2021
@unixorn unixorn deleted the fix-swiftbar-logging-bug branch December 22, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging in Swiftbar
1 participant