Split dependencies into their owning functions' files #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
commented
Nov 8, 2020
| @@ -1,3 +1,5 @@ | |||
| # TODO: REWRITE IF CHANGES DEEMED ACCEPTABLE | |||
There was a problem hiding this comment.
@KingDarBoja do you have any thoughts on the changes here?
There was a problem hiding this comment.
I have nothing against it, as long as there aren't API changes but only moving those dependency definitions into each owning directories. Based on that, pretty much point out that now eachdependency lives on the same file as the function fiels. ⭐
JoshuaKGoldberg
added
the
status: waiting for reviewer
JoshuaKGoldberg
added
status: waiting for author
|
Closing to keep my PR queue small 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Instead of declaring all dependency objects in a single
src/api/dependencies.ts, moves their declarations to be next to the functions that use them.