Skip to content

Investigate moving bound dependencies into their functions' files #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue Nov 8, 2020 · 1 comment
Closed
Assignees
Labels
status: needs investigation Let's dig deeper into this before drawing conclusions.

Comments

@JoshuaKGoldberg
Copy link
Member

Overview

Idea from looking through #732: processLogger needed to be changed to lazily create the write stream... but isn't even used by the Node API. Although it'd be very hard to not import the file at all for the Node API if everything goes through src/index.ts, it'd still be nice to not set up its dependencies unnecessarily.

Actual Behavior

All dependencies are set up in a single src/api/dependencies.ts file right now.

Expected Behavior

Can each function's file import its own dependencies set up and export the function's dependencies object?

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Nov 8, 2020
@JoshuaKGoldberg JoshuaKGoldberg added the status: needs investigation Let's dig deeper into this before drawing conclusions. label Nov 8, 2020
@JoshuaKGoldberg
Copy link
Member Author

Alas, I have again lost interest. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs investigation Let's dig deeper into this before drawing conclusions.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant