Test/dry convert rules 142 #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The end-to-end tests were broken on master. I fixed them and merged into this branch, and will make them less brittle (#216). Sorry if that was confusing! |
JoshuaKGoldberg
approved these changes
Oct 6, 2019
JoshuaKGoldberg
added
the
status: waiting for reviewer
egiurleo
approved these changes
Oct 6, 2019
JoshuaKGoldberg
removed
the
status: waiting for reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Refactored
convertRules.test.tsto be more DRY.I'm a bit unsure whether last commit (17963b5) is a bit too much. Up until commit before (2426714) leaves a bit more configuration in the tests itself but will be more flexible in the future.
@JoshuaKGoldberg @egiurleo Any preferences?