Skip to content

End-to-end TSLint configurations have too many rules enabled #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Oct 6, 2019 · 0 comments
Closed

End-to-end TSLint configurations have too many rules enabled #216

JoshuaKGoldberg opened this issue Oct 6, 2019 · 0 comments
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans

Comments

@JoshuaKGoldberg
Copy link
Member

Each end-to-end test tslint.json has something like 30 rules enabled. That's a lot of rules! The tests shouldn't be including such a large number of rules, as changes to any of them can break the end-to-end tests.

If there are specific things that need to be tested, they should be in their own test. For now I'll reduce the number of rules enabled in end-to-end configurations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduced size of end-to-end test tslint.json rulesets typescript-eslint/tslint-to-eslint-config
1 participant
@JoshuaKGoldberg