Skip to content

Missing merger: whitespace, spacing, one-line #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gliluaume opened this issue Apr 24, 2020 · 4 comments
Closed

Missing merger: whitespace, spacing, one-line #401

gliluaume opened this issue Apr 24, 2020 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@gliluaume
Copy link

gliluaume commented Apr 24, 2020

Hi, tslint-to-eslint-config just asked me to open an issue. I feel sorry in advance because the informations I can provide here might be insufficient to reproduce the issue. But I hope this nevertheless could help.

💥 Missing Merger

  • tslint-to-eslint-config version: 0.6.0
  • ESLint version: 4.19.1

CLI Output

$> npx tslint-to-eslint-config
✨ 79 rules replaced with their ESLint equivalents. ✨

❗ 7 ESLint rules behave differently from their TSLint counterparts ❗
  * camelcase:
    - Leading undescores in variable names will now be ignored.
  * no-underscore-dangle:
    - Leading and trailing underscores (_) on identifiers will now be ignored.
  * no-invalid-this:
    - Functions in methods will no longer be ignored.
  * no-unused-expressions:
    - The TSLint optional config "allow-new" is the default ESLint behavior and will no longer be ignored.
  * prefer-arrow/prefer-arrow-functions:
    - ESLint does not support allowing standalone function declarations.
    - ESLint does not support allowing named functions defined with the function keyword.
  * space-before-function-paren:
    - Option "constructor" is not supported by ESLint.
    - Option "method" is not supported by ESLint.
  * eqeqeq:
    - Option "smart" allows for comparing two literal values, evaluating the value of typeof and null comparisons.

❌ 1 error thrown. ❌
  Check ./tslint-to-eslint-config.log for details.

❓ 4 rules do not yet have ESLint equivalents ❓
  See generated log file; defaulting to eslint-plugin-tslint for these rules.

⚡ 3 packages are required for new ESLint rules. ⚡
  import
  eslint-plugin-jsdoc
  prefer-arrow

✅ All is well! ✅

File Output

$> cat ./tslint-to-eslint-config.log
Error: multiple output @typescript-eslint/triple-slash-reference ESLint rule options were generated, but tslint-to-eslint-config doesn't have "merger" logic to deal with this.
Please file an issue at https://github.com/typescript-eslint/tslint-to-eslint-config/issues/new?template=missing_merger.md 🙏

tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "import-spacing"
tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "no-unused-variable"
tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "one-line"
tslint-to-eslint-config does not know the ESLint equivalent for TSLint's "whitespace"

Reproduction

I am not able to provide a full repository. So please find what I can publish here as attached files.
config.zip

@gliluaume
Copy link
Author

Another point. tslint-to-eslint-config displays:
⚡ 3 packages are required for new ESLint rules. ⚡
import
eslint-plugin-jsdoc
prefer-arrow

Shouldn't it be:
⚡ 3 packages are required for new ESLint rules. ⚡
eslint-plugin-import
eslint-plugin-jsdoc
eslint-plugin-prefer-arrow

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send in a PR to resolve this! ✨ area: missing merger and removed status: accepting prs Please, send in a PR to resolve this! ✨ area: missing merger labels Apr 26, 2020
@JoshuaKGoldberg
Copy link
Member

Thanks for reporting @gliluaume! This is actually a duplicate of #400:

Error: multiple output @typescript-eslint/triple-slash-reference ESLint rule options were generated, but tslint-to-eslint-config doesn't have "merger" logic to deal with this.

The files you posted are enough to reproduce the issue, so this'll be useful in addition to the separate repro steps there. Thank you for going the extra step to share even though the repository isn't open source. 😄

Shouldn't it be:

Correct, and separately fixed in #404. Good eye!

@JoshuaKGoldberg JoshuaKGoldberg added the duplicate This issue or pull request already exists label Apr 26, 2020
@JoshuaKGoldberg
Copy link
Member

As for the missing rules, per the typescript-eslint roadmap:

@gliluaume
Copy link
Author

Ok, thank you! Sorry for having created a duplicate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants