Skip to content

Missing converter: no-unused-variable #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue Apr 26, 2020 · 1 comment · Fixed by #422
Closed

Missing converter: no-unused-variable #411

JoshuaKGoldberg opened this issue Apr 26, 2020 · 1 comment · Fixed by #422
Labels
area: missing converter A rule converter should exist but doesn't yet. good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨

Comments

@JoshuaKGoldberg
Copy link
Member

💥 Missing Converter

  • tslint-to-eslint-config version: 0.6.0
  • typescript-eslint version: 2.29.0

TSLint Rule Name

one-line

See #401 for a reproduction.

The typescript-eslint roadmap indicates @typescript-eslint/no-unused-vars is the ESLint rule to convert to.

Note: that rule has a pretty big caveat in its README.md. There should be a notice in the converter for no-unused-variable that indicates to read the article.

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send in a PR to resolve this! ✨ area: missing converter A rule converter should exist but doesn't yet. good first issue Good for newcomers; welcome aboard! labels Apr 26, 2020
@KingDarBoja
Copy link
Collaborator

That's a long article to read indeed but doesn't seem easy to digest for most users. About the caveat, seems fair to do as this is only turn off the ESLint rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: missing converter A rule converter should exist but doesn't yet. good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants