Skip to content

Missing converter: one-line #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue Apr 26, 2020 · 1 comment · Fixed by #413
Closed

Missing converter: one-line #410

JoshuaKGoldberg opened this issue Apr 26, 2020 · 1 comment · Fixed by #413
Labels
area: missing converter A rule converter should exist but doesn't yet. status: accepting prs Please, send in a PR to resolve this! ✨

Comments

@JoshuaKGoldberg
Copy link
Member

💥 Missing Converter

  • tslint-to-eslint-config version: 0.6.0
  • typescript-eslint version: 2.29.0

TSLint Rule Name

one-line

See #401 for a reproduction.

The typescript-eslint roadmap indicates brace-style is probably the ESLint rule to convert to.

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send in a PR to resolve this! ✨ area: missing converter A rule converter should exist but doesn't yet. labels Apr 26, 2020
@KingDarBoja
Copy link
Collaborator

This one will require a notice as the output rule will use the 1tbs option (enforces one true brace style) and any TSLint option will not be taken into account. In other words, it will check any else, catch, finally are on the same line, no matter what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: missing converter A rule converter should exist but doesn't yet. status: accepting prs Please, send in a PR to resolve this! ✨
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants