Wrong status shown for billing account #1412
Milestone
Comments
jmgasper
added a commit
that referenced
this issue
Sep 2, 2022
#1412 1. A "project" contains "status" field , this status field can be "active"/"in_review" 2. A "project" also has a billingAccount mapped. 3. Application makes a GET call with billingAccount id to get billingAccount details. and response of it is this screenshot https://imgur.com/cU3s4yU 4. response has "active" boolean field and enddate field which is correctly utilised in reducer code to set the flag "isBillingAccountExpired". check this screenshot https://imgur.com/l5nyxbt 5. now this "isBillingAccountExpired" flag is used like this. check screenshot https://imgur.com/mjDhbAF 6. when "isBillingAccountExpired" is true, we show hardcoded "INACTIVE" which is correct. 7. but when "isBillingAccountExpired" is false , we show "status" field of "project" which is wrong, because we need to show whether billingAccount is active or not. 8. hence "status" field of project can be active/inReview , thats why u see "IN_REVIEW" in UI, 9. hence my solution/approach is that flag "isBillingAccountExpired" is already there which clearly indicates active/inactive, hence i hardcoded "ACTIVE" in code because it is obvious.
jmgasper
added a commit
that referenced
this issue
Oct 10, 2022
#1412 1. A "project" contains "status" field , this status field can be "active"/"in_review" 2. A "project" also has a billingAccount mapped. 3. Application makes a GET call with billingAccount id to get billingAccount details. and response of it is this screenshot https://imgur.com/cU3s4yU 4. response has "active" boolean field and enddate field which is correctly utilised in reducer code to set the flag "isBillingAccountExpired". check this screenshot https://imgur.com/l5nyxbt 5. now this "isBillingAccountExpired" flag is used like this. check screenshot https://imgur.com/mjDhbAF 6. when "isBillingAccountExpired" is true, we show hardcoded "INACTIVE" which is correct. 7. but when "isBillingAccountExpired" is false , we show "status" field of "project" which is wrong, because we need to show whether billingAccount is active or not. 8. hence "status" field of project can be active/inReview , thats why u see "IN_REVIEW" in UI, 9. hence my solution/approach is that flag "isBillingAccountExpired" is already there which clearly indicates active/inactive, hence i hardcoded "ACTIVE" in code because it is obvious. # Conflicts: # src/components/ChallengesComponent/ChallengeList/index.js
|
Verified in Prod with available projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Seen in production:
Problem
Today for the Timeline Wall project the billing account was showing
IN_REVIEWIt looks like the Connect Project was In Review, but the Billing Account was active.
Solution
The BA should only show two status - "ACTIVE" or "INACTIVE".
The text was updated successfully, but these errors were encountered: