Skip to content

Commit 5df32c0

Browse files
committed
Fix billing account status display
#1412 1. A "project" contains "status" field , this status field can be "active"/"in_review" 2. A "project" also has a billingAccount mapped. 3. Application makes a GET call with billingAccount id to get billingAccount details. and response of it is this screenshot https://imgur.com/cU3s4yU 4. response has "active" boolean field and enddate field which is correctly utilised in reducer code to set the flag "isBillingAccountExpired". check this screenshot https://imgur.com/l5nyxbt 5. now this "isBillingAccountExpired" flag is used like this. check screenshot https://imgur.com/mjDhbAF 6. when "isBillingAccountExpired" is true, we show hardcoded "INACTIVE" which is correct. 7. but when "isBillingAccountExpired" is false , we show "status" field of "project" which is wrong, because we need to show whether billingAccount is active or not. 8. hence "status" field of project can be active/inReview , thats why u see "IN_REVIEW" in UI, 9. hence my solution/approach is that flag "isBillingAccountExpired" is already there which clearly indicates active/inactive, hence i hardcoded "ACTIVE" in code because it is obvious. # Conflicts: # src/components/ChallengesComponent/ChallengeList/index.js
1 parent e695f7d commit 5df32c0

File tree

1 file changed

+1
-1
lines changed
  • src/components/ChallengesComponent/ChallengeList

1 file changed

+1
-1
lines changed

src/components/ChallengesComponent/ChallengeList/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ class ChallengeList extends Component {
178178
<div className={styles.row}>
179179
{!isBillingAccountLoading && !isBillingAccountLoadingFailed && !isBillingAccountExpired && (
180180
<div className={'col-9'}>
181-
<span className={styles.title}>Billing Account: </span><span className={styles.active}>{activeProject.status}</span> &nbsp; <span className={styles.title}>Start Date:</span> {billingStartDate} &nbsp; <span className={styles.title}>End Date:</span> {billingEndDate}
181+
<span className={styles.title}>Billing Account: </span><span className={styles.active}>ACTIVE</span> &nbsp; <span className={styles.title}>Start Date:</span> {billingStartDate} &nbsp; <span className={styles.title}>End Date:</span> {billingEndDate}
182182
</div>
183183
)}
184184
{!isBillingAccountLoading && !isBillingAccountLoadingFailed && isBillingAccountExpired && (

0 commit comments

Comments
 (0)