Skip to content

issue 3474 fix #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rashmi73
Copy link
Contributor

@urwithat
Copy link

urwithat commented Dec 2, 2019

@rashmi73 & @sushilshinde - I believe this is wrong:
We need to construct the following url:
https://api....com/v3/tags/?filter=domain%3DSKILLS%26status%3DAPPROVED&limit=1000

The current code will construct the url as follows:
/tags/?filter=domain=SKILLS&status=APPROVED&limit=1000

Firstly under the filter param we should have domain & skill and limit would be second param.
Secondly I don't see any conversion to URL escape codes for domain & skill

Kindly fix as per the url required to be formed: /v3/tags/?filter=domain%3DSKILLS%26status%3DAPPROVED&limit=1000

@rashmi73
Copy link
Contributor Author

rashmi73 commented Dec 2, 2019

@urwithat changes have been updated in PR. kindly verify if this is what expected? I guess it should be working now.

@sushilshinde

@urwithat
Copy link

urwithat commented Dec 2, 2019

@rashmi73 - Hope this will handle conversion to URL escape codes for domain & skill
domain%3DSKILLS%26status%3DAPPROVED

@sushilshinde
Copy link
Collaborator

@rashmi73 - Hope this will handle conversion to URL escape codes for domain & skill
domain%3DSKILLS%26status%3DAPPROVED

@rashmi73 please check

@sushilshinde sushilshinde changed the base branch from develop to hot-fixes-2 December 3, 2019 06:57
@sushilshinde
Copy link
Collaborator

@rashmi73 are you fixing this and this is P1, or I will open for pick up again.

@rashmi73
Copy link
Contributor Author

rashmi73 commented Dec 4, 2019

@sushilshinde I am working and it should work

@rashmi73
Copy link
Contributor Author

rashmi73 commented Dec 4, 2019

@sushilshinde it as expected now @urwithat.

Did not take screenshot but it forms url perfectly now. I tested it

@rashmi73
Copy link
Contributor Author

rashmi73 commented Dec 4, 2019

@sushilshinde @urwithat screenshot

3474

@rashmi73
Copy link
Contributor Author

rashmi73 commented Dec 5, 2019

@sushilshinde @urwithat you can merge it now.

@rashmi73
Copy link
Contributor Author

rashmi73 commented Dec 5, 2019

@sushilshinde @urwithat waiting here for feedback or either merging of code

@sushilshinde sushilshinde merged commit 7fdec8f into topcoder-platform:hot-fixes-2 Dec 11, 2019
@sushilshinde
Copy link
Collaborator

sushilshinde commented Dec 11, 2019

@rashmi73
Copy link
Contributor Author

@sushilshinde new PR for lint, #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants