-
Notifications
You must be signed in to change notification settings - Fork 52
issue 3474 fix #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue 3474 fix #114
Conversation
@rashmi73 & @sushilshinde - I believe this is wrong: The current code will construct the url as follows: Firstly under the Kindly fix as per the url required to be formed: |
@urwithat changes have been updated in PR. kindly verify if this is what expected? I guess it should be working now. |
@rashmi73 - Hope this will handle conversion to URL escape codes for |
@rashmi73 are you fixing this and this is P1, or I will open for pick up again. |
@sushilshinde I am working and it should work |
@sushilshinde it as expected now @urwithat. Did not take screenshot but it forms url perfectly now. I tested it |
@sushilshinde @urwithat screenshot |
@sushilshinde @urwithat you can merge it now. |
@sushilshinde @urwithat waiting here for feedback or either merging of code |
@sushilshinde new PR for lint, #117 |
this PR fixes issue topcoder-platform/community-app#3474