Skip to content

[$50]Missing skills on user interface - wrong tags filter used and addition of limit #3474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
urwithat opened this issue Nov 26, 2019 · 37 comments
Closed

[$50]Missing skills on user interface - wrong tags filter used and addition of limit #3474

urwithat opened this issue Nov 26, 2019 · 37 comments
Assignees
@rashmi73
Labels
Member Profiles P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production QA Pass tcx_Assigned tcx_FixAccepted tcx_Paid
Milestone
v0.24.0

Comments

@urwithat
Copy link
Contributor

Describe the bug
Community-app is using tags url which is wrong currently: https://api.topcoder.com/v3/tags/?domain=SKILLS&status=APPROVED

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://www.topcoder.com/settings/profile#skills'
  2. Open developer console network tab

Expected behavior
Need to change to https://api.topcoder-dev.com/v3/tags/?filter=domain%3DSKILLS%26status%3DAPPROVED&limit=1000
@urwithat urwithat added the P1 Urgent (resolve within 24 hours) label Nov 26, 2019
@sushilshinde sushilshinde changed the title Missing skills on user interface - wrong tags filter used and addition of limit [$50]Missing skills on user interface - wrong tags filter used and addition of limit Nov 27, 2019
@sushilshinde sushilshinde removed their assignment Nov 27, 2019
@sushilshinde
Copy link
Collaborator

Use https://github.com/topcoder-platform/community-app/tree/hot-fixes-1 for PR

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

@rashmi73 rashmi73 self-assigned this Nov 27, 2019
@rashmi73
Copy link
Contributor

@sushilshinde a minor confusion based on requirements above

do i need to change from "api.topcoder.com" to "api.topcoder-dev.com" or is it by mistakely written above?

@sushilshinde
Copy link
Collaborator

sushilshinde commented Nov 27, 2019 •
edited
Loading

domain part will always remain dynamic so no change there

Change required :
filter=domain%3DSKILLS%26status%3DAPPROVED&limit=1000

FYI @urwithat

@urwithat
Copy link
Contributor Author

@sushilshinde - perfect

@rashmi73
Copy link
Contributor

@sushilshinde actually this change is on topcoder-react-lib side, my changes are done but unaware on which branch it is to be raised, hence assuming on my side and raising PR on dev branch

@rashmi73 rashmi73 mentioned this issue Nov 27, 2019
Merged
@rashmi73
Copy link
Contributor

@sushilshinde PR is at topcoder-react-lib repo topcoder-platform/topcoder-react-lib#114

@sushilshinde
Copy link
Collaborator

@rashmi73 please follow the instructions

#3474 (comment)

@rashmi73
Copy link
Contributor

@sushilshinde I guess you misunderstood, because code for above solution is not present in community-app, it is at https://github.com/topcoder-platform/topcoder-react-lib/

can you please say which branch to use then?

@rashmi73
Copy link
Contributor

@sushilshinde @urwithat are we merging this?

@codeMinter
Copy link
Contributor

@sushilshinde @urwithat are we merging this?

@rashmi73 kindly fix PR, follow notes here #3474 (comment)

@rashmi73
Copy link
Contributor

@codeMinter yes I read comment which says PR on community app hot-fixes-1, but solution to this issue does not require PR on community app, rather it is topcoder-react-lib repo. hence I raised PR on it against dev branch. this is what I am trying to convey above. kindly confirm if m wrong or something is missed by me or something else expected?

@sushilshinde Hope so its efforts wont go waste as already happened twice with me.

@codeMinter
Copy link
Contributor

@codeMinter yes I read comment which says PR on community app hot-fixes-1, but solution to this issue does not require PR on community app, rather it is topcoder-react-lib repo. hence I raised PR on it against dev branch. this is what I am trying to convey above. kindly confirm if m wrong or something is missed by me or something else expected?

@sushilshinde Hope so its efforts wont go waste as already happened twice with me.

@rashmi73 got it. The pipeline is busy, if you see I also have 2 tickets waiting for deployment. So we need to wait till it gets free for deployment. It will be merged once pipeline gets cleared.

@urwithat
Copy link
Contributor Author

urwithat commented Dec 2, 2019

@sushilshinde - Is this available in dev as yet?

@sushilshinde
Copy link
Collaborator

@rashmi73 can you make this changes?

topcoder-platform/topcoder-react-lib#114 (comment)

@sushilshinde
Copy link
Collaborator

sushilshinde commented Dec 3, 2019 •
edited
Loading

@rashmi73 I changed PR's base branch to hot-fixes-2

@SathyaJayabal
Copy link
Collaborator

Verified on dev env (hot fix branch) and topcoder-react-lib version "1000.6.3"
Screenshot 2020-03-09 at 10 38 47 AM

@LieutenantRoger LieutenantRoger mentioned this issue Mar 9, 2020
Merged
sushilshinde added a commit to topcoder-platform/topcoder-react-lib that referenced this issue Mar 9, 2020
@sushilshinde
release : fix for missing skills on user interface
44e7dc5 
topcoder-platform/community-app#3474
@sushilshinde sushilshinde mentioned this issue Mar 9, 2020
Merged
sushilshinde added a commit that referenced this issue Mar 9, 2020
@sushilshinde
release: hot fix for missing skills tag
d2b4e41 
#3474
@sushilshinde sushilshinde mentioned this issue Mar 9, 2020
Merged
@lakshmiathreya lakshmiathreya added Beta Env Environment QA Pass and removed QA Pass labels Mar 9, 2020
@lakshmiathreya lakshmiathreya added this to the 0.23.02 milestone Mar 9, 2020
@drasticdpk
Copy link
Collaborator

Verified on Beta Env :
image

@LieutenantRoger
Copy link
Collaborator

Thank you @drasticdpk

@LieutenantRoger LieutenantRoger mentioned this issue Mar 11, 2020
Merged
@macs054
Copy link
Collaborator

macs054 commented Mar 11, 2020

Verified in Prod
image

@macs054 macs054 closed this as completed Mar 11, 2020
@macs054 macs054 added QA Pass in PROD Passed verification on Production and removed Beta Env Environment Dev Env labels Mar 11, 2020
@crazyk07 crazyk07 added Beta Env Environment Dev Env tcx_Assigned tcx_Paid and removed QA Pass in PROD Passed verification on Production labels Mar 11, 2020
@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30115720

This is an automated message for crazyk via Topcoder X

@macs054 macs054 added QA Pass in PROD Passed verification on Production and removed Beta Env Environment Dev Env labels Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rashmi73 rashmi73

Labels
Member Profiles P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production QA Pass tcx_Assigned tcx_FixAccepted tcx_Paid
Projects
None yet
Milestone
v0.24.0
Development

No branches or pull requests