-
Notifications
You must be signed in to change notification settings - Fork 33
implement local event handling #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement local event handling #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imcaizheng, automatic updates doesn't work for me. When I make any action which supposes to trigger automatic updates, I get error.
@maxceem I tried to resolve the conflict between the PR and dev branch but I did it wrongly. Please discard the last commit and merge the last but one, named |
@imcaizheng hmm, I don't think there is a way to discard the last commit during merging. Could you please, revert the wrong commit from |
@maxceem Thanks. The change is reverted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxceem Thanks. The change is reverted.
@imcaizheng Looks like during merging changes that were done for permissions in this PR #77 were reverted.
I try to test functionality anyway:
- When I assign Resouce Booking the corresponding JobCandidate became 'selected'.
- But if I cancel Job, corresponding Resource Booking and JobCandidates are not cancelled.
@maxceem EDIT |
Notes
src/app-routes.js
and inside functionResourceBookingService.updateResourceBooking
are slightly alteredto work with the event handling. Please review these changes particularly to ensure nothing would be broken due to that.