Skip to content

fix permission rules as per issue #72 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 25, 2020

Conversation

imcaizheng
Copy link
Contributor

Validation

In postman collection new folder named "Test Permission Rules" is added to provide basic requests for validating the permission rules with different roles.

Notes

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @imcaizheng. As per my testing, Topcoder User can get JobCandidates and ResourceBooking created in the project where Topcoder User doesn't have access to.

If I create a job in project 111 using admin

image

After that, if I request JobCandidates by Topcoder User filtered by jobId with that job in project 111, I would get an empty list of jobCandidates:

image

While an expected result should be 403 as Topcoder User doesn't have access to the project 111 of that Job.

And if I create JobCandates in that job, then Topcoder User could access them:

image

Also, can get JobCandidate by id from project 111:
image

The same for ResouceBookings, can get it by id even don't have access to the project 111

image

Everything else, work good to me. Let me know if you can reproduce the issues above, or I missed something during testing.

@imcaizheng imcaizheng requested a review from maxceem December 24, 2020 00:47
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @imcaizheng. Works perfectly now.

@maxceem maxceem merged commit 5ccfb7a into topcoder-platform:dev Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants