Fix PUT operations: fully replace the content of a record with a new one #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imcaizheng
commented
Feb 9, 2021
| @@ -2003,7 +2003,6 @@ components: | |||
| required: | |||
| - projectId | |||
| - userId | |||
| - status | |||
There was a problem hiding this comment.
I believed that, in order to be consistent, in the PUT operation status should have a default value like in the POST operation. So status is no longer being a required field.
|
@imcaizheng PR looks good to me. Could you please, resolve the merge conflict after merging the previous PR. |
|
@maxceem PR updated. |
maxceem
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
Thank you for so quick update @imcaizheng.
Works good as per local testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots as Verification
PUT /jobs/:jobId
PUT /jobCandidates/:jobCandidateId
PUT /resourceBookings/:resourceBookingId