[$50] PUT requests work same like PATCH requests

[maxceem]

We have PUT and PATCH requests. Their logic suppose to be different, but they work the same and have the logic of the PATCH request.

Example:

Create Job with "workload": "full-time":

{
  "projectId": {{projectId}},
  "numPositions": 13,
  "resourceType": "Dummy Resource Type",
  "workload": "full-time",
  "skills": [],
  "title": "Dummy title - at most 64 characters"
}

Now PUT the same job using the same request, but without workload field:

{
  "projectId": {{projectId}},
  "numPositions": 13,
  "resourceType": "Dummy Resource Type",
  "skills": [],
  "title": "Dummy title - at most 64 characters UPDATED"
}

The expected outcome of the PUT operation is that it replaces the whole Job object with a new object. But it merges previous object with a new object like a PATCH request and the resulting object still has workload:

{
    "id": "0668312e-f60f-44e9-94e2-bf3172f173f2",
    "projectId": 111,
    "numPositions": 13,
    "resourceType": "Dummy Resource Type",
    "workload": "full-time",
    "skills": [],
    "title": "Dummy title - at most 64 characters UPDATED",
    "status": "sourcing",
    "createdBy": "57646ff9-1cd3-4d3c-88ba-eb09a395366c",
    "updatedAt": "2021-02-09T09:12:11.568Z",
    "createdAt": "2021-02-09T09:09:47.090Z",
    "externalId": null,
    "description": null,
    "startDate": null,
    "endDate": null,
    "rateType": null,
    "updatedBy": "57646ff9-1cd3-4d3c-88ba-eb09a395366c"
}

We have to fix the PUT logic, so when we PUT a new object all existent values are replaced with new values as if we created a new object using new data. All previous data of the object should disappear (except "createdBy"/"createdAt").

[maxceem]

@nkumar-topcoder @imcaizheng could you please have a look on this issue, what do you think is it valid? Should it be expected that not defined values are removed from the object when we PUT? Otherwise, I don't see any difference between PUT and PATCH.

[imcaizheng]

The submissions-api(https://github.com/topcoder-platform/submissions-api) is used as a reference when taas-apis was initially implemented as per the spec from https://www.topcoder.com/challenges/90eef3e3-1218-403a-adac-fbda5f46a615?tab=details.

By looking at the source code of submissions-api(e.g. https://github.com/topcoder-platform/submissions-api/blob/develop/src/services/SubmissionService.js#L385-L444), we could say it does not quite distinguish between patch and put. The put request acts more like a bulky version of the patch request.

@maxceem I agree that we should implement a "true" PUT operation that can entirely replace the content of a record.

[maxceem]

Challenge https://www.topcoder.com/challenges/d3a4f176-45c0-4f7d-83af-0d44c4ff3728 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

[maxceem]

@imcaizheng thank you for the details, I really appreciate your input.
This issue is ready for pickup. But please, give priority to #143.

I'm setting the price for this ticket as I'm expecting that it's straightforward to fix. But if it's not, please let me know.

[maxceem]

Challenge https://www.topcoder.com/challenges/d3a4f176-45c0-4f7d-83af-0d44c4ff3728 has been assigned to aaron2017.

This is an automated message for maxceem via Topcoder X

[imcaizheng]

PR created #146