Skip to content

[Role API] The skills and keyword search does not return any results #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Jun 2, 2021 · 9 comments
Closed

[Role API] The skills and keyword search does not return any results #293

sdgun opened this issue Jun 2, 2021 · 9 comments

Comments

@sdgun
Copy link
Collaborator

sdgun commented Jun 2, 2021

Steps
Call GET https://api.topcoder-dev.com/v5/taas-roles/?skillsList=aws lambda&keyword=aws from a valid user token

Current behavior
Search by both skills and keyword does not return results

Expected behavior
Should return matching results

@sdgun sdgun added bug Something isn't working P1 Role-Matching-Intake labels Jun 2, 2021
@eisbilir
Copy link
Member

eisbilir commented Jun 2, 2021

@sdgun @nikolay83
To make it clear, we expect matching results to have both aws lambda skill in it's skillsLists and include aws in it's name, right?
Both condition should be satisfied. It might be deleted after but I couldn't find any matching roles at GET https://api.topcoder-dev.com/v5/taas-roles/

I made both skillList and keyword criteria case insensitive now.
PR created: #299

nikolay83 added a commit that referenced this issue Jun 3, 2021
@sdgun sdgun added the Dev env label Jun 4, 2021
@sdgun
Copy link
Collaborator Author

sdgun commented Jun 4, 2021

@eisbilir Noticed keyword is still case sensitive.

2021-06-04_12-34-27.mp4

@nikolay83 Are we only checking keyword in the name?

@sdgun @nikolay83
To make it clear, we expect matching results to have both aws lambda skill in it's skillsLists and include aws in it's name, right?
Both condition should be satisfied. It might be deleted after but I couldn't find any matching roles at GET https://api.topcoder-dev.com/v5/taas-roles/

I made both skillList and keyword criteria case insensitive now.
PR created: #299

@eisbilir
Copy link
Member

eisbilir commented Jun 4, 2021

@nikolay83 Could you confirm Role index is recreated with new mapping settings after this fix?
Because searching works good on local

@nikolay83
Copy link
Collaborator

Confirmed.

@sdgun
Copy link
Collaborator Author

sdgun commented Jun 22, 2021

Cannot verify until topcoder-archive/topcoder-platform-taas-app#342 is fixed.

@sdgun
Copy link
Collaborator Author

sdgun commented Jun 23, 2021

This issue still exists in Dev. Both skills list and keyword are case sensitive

2021-06-23_14-35-29.mp4

@sdgun
Copy link
Collaborator Author

sdgun commented Jun 24, 2021

@nikolay83 Please note this issue is not fixed yet

2021-06-24_8-34-29.mp4

@eisbilir
Copy link
Member

@nikolay83 @sdgun
This was failing because no re-indexing was done after fix.
According to #370 (comment) , re-indexing is now done.
So both skills list and keyword should be case insensitive now.

@sdgun
Copy link
Collaborator Author

sdgun commented Jun 29, 2021

Verified in Dev, this issue is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants